Mesa (master): i965: Fix assertion in brw_alu3.

Vinson Lee vlee at kemper.freedesktop.org
Thu Nov 8 06:54:40 UTC 2012


Module: Mesa
Branch: master
Commit: 4cb8b946d9b404da4f72cdb70d07c2283df3922e
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=4cb8b946d9b404da4f72cdb70d07c2283df3922e

Author: Vinson Lee <vlee at freedesktop.org>
Date:   Tue Nov  6 23:37:20 2012 -0800

i965: Fix assertion in brw_alu3.

Fixes side effect in assertion defect reported by Coverity.

Signed-off-by: Vinson Lee <vlee at freedesktop.org>
Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>

---

 src/mesa/drivers/dri/i965/brw_eu_emit.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/src/mesa/drivers/dri/i965/brw_eu_emit.c b/src/mesa/drivers/dri/i965/brw_eu_emit.c
index 3d95b92..eada9d9 100644
--- a/src/mesa/drivers/dri/i965/brw_eu_emit.c
+++ b/src/mesa/drivers/dri/i965/brw_eu_emit.c
@@ -779,7 +779,7 @@ static struct brw_instruction *brw_alu3(struct brw_compile *p,
 	  dest.file == BRW_MESSAGE_REGISTER_FILE);
    assert(dest.nr < 128);
    assert(dest.address_mode == BRW_ADDRESS_DIRECT);
-   assert(dest.type = BRW_REGISTER_TYPE_F);
+   assert(dest.type == BRW_REGISTER_TYPE_F);
    insn->bits1.da3src.dest_reg_file = (dest.file == BRW_MESSAGE_REGISTER_FILE);
    insn->bits1.da3src.dest_reg_nr = dest.nr;
    insn->bits1.da3src.dest_subreg_nr = dest.subnr / 16;




More information about the mesa-commit mailing list