Mesa (master): i965: Fix AA Line Distance Mode in 3DSTATE_SF on Ivybridge.
Kenneth Graunke
kwg at kemper.freedesktop.org
Sat Nov 10 20:16:42 UTC 2012
Module: Mesa
Branch: master
Commit: e639385064663ba401544de5dbd463fa7f6cce2d
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=e639385064663ba401544de5dbd463fa7f6cce2d
Author: Kenneth Graunke <kenneth at whitecape.org>
Date: Thu Nov 8 04:13:26 2012 -0800
i965: Fix AA Line Distance Mode in 3DSTATE_SF on Ivybridge.
We were accidentally setting bit 14 in DWord 2 (which is Reserved/MBZ)
rather than bit 14 in DWord 3 (which is AA Line Distance Mode).
There's also no reason to ever set it to legacy mode; the bit is only
used when drawing antialiased lines anyway. Set it unconditionally.
NOTE: This is a candidate for stable branches.
Signed-off-by: Kenneth Graunke <kenneth at whitecape.org>
Reviewed-by: Eric Anholt <eric at anholt.net>
---
src/mesa/drivers/dri/i965/gen7_sf_state.c | 4 +---
1 files changed, 1 insertions(+), 3 deletions(-)
diff --git a/src/mesa/drivers/dri/i965/gen7_sf_state.c b/src/mesa/drivers/dri/i965/gen7_sf_state.c
index 871a8b7..28c6508 100644
--- a/src/mesa/drivers/dri/i965/gen7_sf_state.c
+++ b/src/mesa/drivers/dri/i965/gen7_sf_state.c
@@ -253,7 +253,6 @@ upload_sf_state(struct brw_context *brw)
}
if (ctx->Line.SmoothFlag) {
dw2 |= GEN6_SF_LINE_AA_ENABLE;
- dw2 |= GEN6_SF_LINE_AA_MODE_TRUE;
dw2 |= GEN6_SF_LINE_END_CAP_WIDTH_1_0;
}
if (ctx->Line.StippleFlag && intel->is_haswell) {
@@ -264,10 +263,9 @@ upload_sf_state(struct brw_context *brw)
dw2 |= GEN6_SF_MSRAST_ON_PATTERN;
/* FINISHME: Last Pixel Enable? Vertex Sub Pixel Precision Select?
- * FINISHME: AA Line Distance Mode?
*/
- dw3 = 0;
+ dw3 = GEN6_SF_LINE_AA_MODE_TRUE;
/* _NEW_PROGRAM | _NEW_POINT */
if (!(ctx->VertexProgram.PointSizeEnabled || ctx->Point._Attenuated))
More information about the mesa-commit
mailing list