Mesa (master): i965/vs: Don' t lose attribute type when converting ATTR to FIXED_HW_REG.

Kenneth Graunke kwg at kemper.freedesktop.org
Mon Nov 19 21:28:12 UTC 2012


Module: Mesa
Branch: master
Commit: 4e907018b2b7d18fee1359fa877079af45e012af
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=4e907018b2b7d18fee1359fa877079af45e012af

Author: Kenneth Graunke <kenneth at whitecape.org>
Date:   Sun Nov 18 23:51:47 2012 -0800

i965/vs: Don't lose attribute type when converting ATTR to FIXED_HW_REG.

The new brw_reg always had type BRW_REGISTER_TYPE_F, rather than
inheriting the original type of the ATTR file register.

In the past, this hasn't been a problem since we only execute this code
when fixing up GL_FIXED attributes, which always have float types.
However, we'll soon be using it for ARB_vertex_type_10_10_10_2 support,
which uses D and UD types.

Reviewed-by: Eric Anholt <eric at anholt.net>

---

 src/mesa/drivers/dri/i965/brw_vec4_emit.cpp |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/src/mesa/drivers/dri/i965/brw_vec4_emit.cpp b/src/mesa/drivers/dri/i965/brw_vec4_emit.cpp
index c9fdc16..a162420 100644
--- a/src/mesa/drivers/dri/i965/brw_vec4_emit.cpp
+++ b/src/mesa/drivers/dri/i965/brw_vec4_emit.cpp
@@ -65,6 +65,7 @@ vec4_visitor::setup_attributes(int payload_reg)
 	 int grf = attribute_map[inst->dst.reg + inst->dst.reg_offset];
 
 	 struct brw_reg reg = brw_vec8_grf(grf, 0);
+	 reg.type = inst->dst.type;
 	 reg.dw1.bits.writemask = inst->dst.writemask;
 
 	 inst->dst.file = HW_REG;




More information about the mesa-commit mailing list