Mesa (master): mesa: Mark GetBufferParameteri64v as implemented.

Kenneth Graunke kwg at kemper.freedesktop.org
Mon Nov 19 21:28:18 UTC 2012


Module: Mesa
Branch: master
Commit: 1f74a5b3ccb416feb753c5e8feb9531228179743
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=1f74a5b3ccb416feb753c5e8feb9531228179743

Author: Kenneth Graunke <kenneth at whitecape.org>
Date:   Sat Nov 17 20:51:42 2012 -0800

mesa: Mark GetBufferParameteri64v as implemented.

Apparently this was accidentally marked as unimplemented, and thus not
put in the dispatch table.

Fixes 7 es3conform tests:
- copy_buffer_parameters
- copy_buffer_data
- copy_buffer_usage
- pixel_buffer_object_bind
- pixel_buffer_object_parameteriv
- pixel_buffer_object_texture_read
- pixel_buffer_object_usage

v2: Also update the DispatchSanity test for this change.

Reviewed-by: Matt Turner <mattst88 at gmail.com>

---

 src/mapi/glapi/gen/GL3x.xml             |    3 +--
 src/mesa/main/tests/dispatch_sanity.cpp |    3 +--
 2 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/src/mapi/glapi/gen/GL3x.xml b/src/mapi/glapi/gen/GL3x.xml
index 83b5d49..1b7addd 100644
--- a/src/mapi/glapi/gen/GL3x.xml
+++ b/src/mapi/glapi/gen/GL3x.xml
@@ -601,8 +601,7 @@
     <param name="data" type="GLint64 *"/>
   </function>
 
-  <function name="GetBufferParameteri64v" offset="assign" es2="3.0"
-            exec="skip">
+  <function name="GetBufferParameteri64v" offset="assign" es2="3.0">
     <param name="target" type="GLenum"/>
     <param name="pname" type="GLenum"/>
     <param name="params" type="GLint64 *"/>
diff --git a/src/mesa/main/tests/dispatch_sanity.cpp b/src/mesa/main/tests/dispatch_sanity.cpp
index 56f0dfb..a7c6f8f 100644
--- a/src/mesa/main/tests/dispatch_sanity.cpp
+++ b/src/mesa/main/tests/dispatch_sanity.cpp
@@ -1301,8 +1301,7 @@ const struct function gles3_functions_possible[] = {
    { "glGetActiveUniformBlockiv", 30, -1 },
    { "glGetActiveUniformBlockName", 30, -1 },
    { "glGetActiveUniformsiv", 30, -1 },
-   // We have an implementation (added Jan 1 2010, 1fbc7193) but never tested...
-   // { "glGetBufferParameteri64v", 30, -1 },
+   { "glGetBufferParameteri64v", 30, -1 },
    // We check for the aliased -OES version in GLES 2
    // { "glGetBufferPointerv", 30, -1 },
    { "glGetFragDataLocation", 30, -1 },




More information about the mesa-commit mailing list