Mesa (master): i965/fs: Abort on unsupported opcodes rather than failing.

Kenneth Graunke kwg at kemper.freedesktop.org
Tue Nov 27 04:48:57 UTC 2012


Module: Mesa
Branch: master
Commit: dd1fd300473bd58929e5a1b1a5e5a0e82af9d7cf
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=dd1fd300473bd58929e5a1b1a5e5a0e82af9d7cf

Author: Kenneth Graunke <kenneth at whitecape.org>
Date:   Tue Nov 20 17:02:23 2012 -0800

i965/fs: Abort on unsupported opcodes rather than failing.

Final code generation should never fail.  This is a bug, and there
should be no user-triggerable cases where this could occur.

Also, we're not going to have a fail() method in a moment.

v2: Just abort() rather than assert, to cover the NDEBUG case
    (suggested by Eric).

Reviewed-by: Eric Anholt <eric at anholt.net>
Reviewed-by: Paul Berry <stereotype441 at gmail.com>

---

 src/mesa/drivers/dri/i965/brw_fs_emit.cpp |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/src/mesa/drivers/dri/i965/brw_fs_emit.cpp b/src/mesa/drivers/dri/i965/brw_fs_emit.cpp
index 4a1700b..f04d90d 100644
--- a/src/mesa/drivers/dri/i965/brw_fs_emit.cpp
+++ b/src/mesa/drivers/dri/i965/brw_fs_emit.cpp
@@ -1012,7 +1012,7 @@ fs_visitor::generate_code()
 	 } else {
 	    _mesa_problem(ctx, "Unsupported opcode %d in FS", inst->opcode);
 	 }
-	 fail("unsupported opcode in FS\n");
+	 abort();
       }
 
       if (unlikely(INTEL_DEBUG & DEBUG_WM)) {




More information about the mesa-commit mailing list