Mesa (master): i965/vs: Abort on unsupported opcodes rather than failing.
Kenneth Graunke
kwg at kemper.freedesktop.org
Thu Nov 29 02:17:13 UTC 2012
Module: Mesa
Branch: master
Commit: db6231fece32a0cec6050ca570a04362036f4f48
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=db6231fece32a0cec6050ca570a04362036f4f48
Author: Kenneth Graunke <kenneth at whitecape.org>
Date: Mon Nov 26 21:56:06 2012 -0800
i965/vs: Abort on unsupported opcodes rather than failing.
Final code generation should never fail. This is a bug, and there
should be no user-triggerable cases where this could occur.
Also, we're not going to have a fail() method after the split.
Reviewed-by: Eric Anholt <eric at anholt.net>
Reviewed-by: Anuj Phogat <anuj.phogat at gmail.com>
---
src/mesa/drivers/dri/i965/brw_vec4_emit.cpp | 7 ++++---
1 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/src/mesa/drivers/dri/i965/brw_vec4_emit.cpp b/src/mesa/drivers/dri/i965/brw_vec4_emit.cpp
index b911983..a2a5975 100644
--- a/src/mesa/drivers/dri/i965/brw_vec4_emit.cpp
+++ b/src/mesa/drivers/dri/i965/brw_vec4_emit.cpp
@@ -641,11 +641,12 @@ vec4_visitor::generate_vs_instruction(vec4_instruction *instruction,
default:
if (inst->opcode < (int) ARRAY_SIZE(opcode_descs)) {
- fail("unsupported opcode in `%s' in VS\n",
- opcode_descs[inst->opcode].name);
+ _mesa_problem(ctx, "Unsupported opcode in `%s' in VS\n",
+ opcode_descs[inst->opcode].name);
} else {
- fail("Unsupported opcode %d in VS", inst->opcode);
+ _mesa_problem(ctx, "Unsupported opcode %d in VS", inst->opcode);
}
+ abort();
}
}
More information about the mesa-commit
mailing list