Mesa (master): egl: Remove bogus invalidate code.

Eric Anholt anholt at kemper.freedesktop.org
Tue Oct 9 21:34:11 UTC 2012


Module: Mesa
Branch: master
Commit: 1e7776ca2bc59a6978d9b933d23852d47078dfa8
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=1e7776ca2bc59a6978d9b933d23852d47078dfa8

Author: Eric Anholt <eric at anholt.net>
Date:   Tue Sep 25 14:45:16 2012 -0700

egl: Remove bogus invalidate code.

The invalidate event support is a careful dance between driver and loader,
where both have to say they can handle it, and then the loader reports
invalidate events for the driver so the driver can do the optimization.

The EGL code doesn't report __DRIuseInvalidateExtension to the driver, so it
has no responsibility to call the driver's invalidate function, and the driver
is doing the glViewport hack because it assume.  This is not
the only time invalidate would need to be called (we need it *any* time an
invalidate event comes down the pipe, but we don't watch for them), so just
stop calling the driver's function.

Acked-by: Chad Versace <chad.versace at linux.intel.com>

---

 src/egl/drivers/dri2/platform_x11.c |    5 -----
 1 files changed, 0 insertions(+), 5 deletions(-)

diff --git a/src/egl/drivers/dri2/platform_x11.c b/src/egl/drivers/dri2/platform_x11.c
index 4757ccf..936e380 100644
--- a/src/egl/drivers/dri2/platform_x11.c
+++ b/src/egl/drivers/dri2/platform_x11.c
@@ -742,11 +742,6 @@ dri2_swap_buffers_msc(_EGLDriver *drv, _EGLDisplay *disp, _EGLSurface *draw,
       free(reply);
    }
 
-   /* If the server doesn't send invalidate events */
-   if (dri2_dpy->invalidate_available && dri2_dpy->flush &&
-       dri2_dpy->flush->base.version >= 3 && dri2_dpy->flush->invalidate)
-      (*dri2_dpy->flush->invalidate)(dri2_surf->dri_drawable);
-
    return swap_count;
 }
 




More information about the mesa-commit mailing list