Mesa (master): mapi_abi: Remove sanity check that all GLES functions are present.

Paul Berry stereotype441 at kemper.freedesktop.org
Tue Oct 16 19:06:02 UTC 2012


Module: Mesa
Branch: master
Commit: 77ed171f27de5c4f50720263b419e26d6715e621
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=77ed171f27de5c4f50720263b419e26d6715e621

Author: Paul Berry <stereotype441 at gmail.com>
Date:   Wed Oct 10 15:07:00 2012 -0700

mapi_abi: Remove sanity check that all GLES functions are present.

Currently mapi_abi.py uses hardcoded lists of function names (in
gles_api.py) to determine which functions need to be included in the
GLES 1 or GLES 2 API.  This patch removes a sanity check which
verified that all GLES functions listed in the hardcoded lists were
actually present in the XML.

Later patches in this series will modify mapi_abi.py to determine
which functions need to be included in the GLES 1 or GLES 2 API based
directly on the XML.  Once that is done, the sanity check will be
redundant.  Removing the sanity check now will simplify the patches to
come.

Tested-by: Matt Turner <mattst88 at gmail.com>
Reviewed-by: Ian Romanick <ian.d.romanick at intel.com>

---

 src/mapi/mapi/mapi_abi.py |    5 -----
 1 files changed, 0 insertions(+), 5 deletions(-)

diff --git a/src/mapi/mapi/mapi_abi.py b/src/mapi/mapi/mapi_abi.py
index 4fd1582..ce4e047 100644
--- a/src/mapi/mapi/mapi_abi.py
+++ b/src/mapi/mapi/mapi_abi.py
@@ -730,11 +730,6 @@ class GLAPIPrinter(ABIPrinter):
 
             api_entries[ent.name] = ent
 
-        # sanity check
-        missed = [name for name in api if name not in api_entries]
-        if missed:
-            raise Exception('%s is missing' % str(missed))
-
         entries = api_entries.values()
         entries.sort()
 




More information about the mesa-commit mailing list