Mesa (master): mesa/st: Don't use 4bits for GL_UNSIGNED_BYTE_3_3_2(_REV)

Jose Fonseca jrfonseca at kemper.freedesktop.org
Thu Oct 25 17:06:27 UTC 2012


Module: Mesa
Branch: master
Commit: 0cb0c38ccea84ab524d10447585000d41fbb8c74
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=0cb0c38ccea84ab524d10447585000d41fbb8c74

Author: José Fonseca <jfonseca at vmware.com>
Date:   Thu Oct 25 15:47:12 2012 +0100

mesa/st: Don't use 4bits for GL_UNSIGNED_BYTE_3_3_2(_REV)

4bits and 3bits quantitization values differ significantly for
values other than 0 and 1.

Fixes piglit draw-pixels for softpipe/llvmpipe.

NOTE: Probably a candidate for stable branches.

Reviewed-by: Brian Paul <brianp at vmware.com>
Reviewed-by: Marek Olšák <maraeo at gmail.com>

---

 src/mesa/state_tracker/st_cb_drawpixels.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/src/mesa/state_tracker/st_cb_drawpixels.c b/src/mesa/state_tracker/st_cb_drawpixels.c
index 4e2edd2..6420114 100644
--- a/src/mesa/state_tracker/st_cb_drawpixels.c
+++ b/src/mesa/state_tracker/st_cb_drawpixels.c
@@ -396,6 +396,8 @@ internal_format(struct gl_context *ctx, GLenum format, GLenum type)
 
          case GL_UNSIGNED_BYTE_3_3_2:
          case GL_UNSIGNED_BYTE_2_3_3_REV:
+            return GL_R3_G3_B2;
+
          case GL_UNSIGNED_SHORT_4_4_4_4:
          case GL_UNSIGNED_SHORT_4_4_4_4_REV:
             return GL_RGBA4;




More information about the mesa-commit mailing list