Mesa (master): tools/trace: More helpful message when no args are provided.

Jose Fonseca jrfonseca at kemper.freedesktop.org
Fri Oct 26 10:01:51 UTC 2012


Module: Mesa
Branch: master
Commit: 4a9341498582891761e91599729adf6f2e2728a8
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=4a9341498582891761e91599729adf6f2e2728a8

Author: José Fonseca <jfonseca at vmware.com>
Date:   Fri Oct 26 09:46:29 2012 +0100

tools/trace: More helpful message when no args are provided.

---

 src/gallium/tools/trace/parse.py |   26 +++++++++++++-------------
 1 files changed, 13 insertions(+), 13 deletions(-)

diff --git a/src/gallium/tools/trace/parse.py b/src/gallium/tools/trace/parse.py
index b08d368..feb0b64 100755
--- a/src/gallium/tools/trace/parse.py
+++ b/src/gallium/tools/trace/parse.py
@@ -364,23 +364,23 @@ class Main:
         optparser = self.get_optparser()
         (options, args) = optparser.parse_args(sys.argv[1:])
     
-        if args:
-            for arg in args:
-                if arg.endswith('.gz'):
-                    from gzip import GzipFile
-                    stream = GzipFile(arg, 'rt')
-                elif arg.endswith('.bz2'):
-                    from bz2 import BZ2File
-                    stream = BZ2File(arg, 'rU')
-                else:
-                    stream = open(arg, 'rt')
-                self.process_arg(stream, options)
-        else:
+        if not args:
+            optparser.error('insufficient number of arguments')
+
+        for arg in args:
+            if arg.endswith('.gz'):
+                from gzip import GzipFile
+                stream = GzipFile(arg, 'rt')
+            elif arg.endswith('.bz2'):
+                from bz2 import BZ2File
+                stream = BZ2File(arg, 'rU')
+            else:
+                stream = open(arg, 'rt')
             self.process_arg(stream, options)
 
     def get_optparser(self):
         optparser = optparse.OptionParser(
-            usage="\n\t%prog [options] [traces] ...")
+            usage="\n\t%prog [options] TRACE  [...]")
         return optparser
 
     def process_arg(self, stream, options):




More information about the mesa-commit mailing list