Mesa (master): ilo: fix a potential issue with STATE_SIP

Chia-I Wu olv at kemper.freedesktop.org
Thu Aug 22 07:20:46 UTC 2013


Module: Mesa
Branch: master
Commit: 627d7ca7631c6835f22f2f945c11abba24a650e4
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=627d7ca7631c6835f22f2f945c11abba24a650e4

Author: Chia-I Wu <olvaffe at gmail.com>
Date:   Thu Aug 22 14:53:11 2013 +0800

ilo: fix a potential issue with STATE_SIP

Command length is ORed to the wrong place.  Since the ORed value is zero,
there is no real change.

---

 src/gallium/drivers/ilo/ilo_gpe_gen6.h |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/gallium/drivers/ilo/ilo_gpe_gen6.h b/src/gallium/drivers/ilo/ilo_gpe_gen6.h
index f9bffa9..8f005e9 100644
--- a/src/gallium/drivers/ilo/ilo_gpe_gen6.h
+++ b/src/gallium/drivers/ilo/ilo_gpe_gen6.h
@@ -432,8 +432,8 @@ gen6_emit_STATE_SIP(const struct ilo_dev_info *dev,
 
    ILO_GPE_VALID_GEN(dev, 6, 7);
 
-   ilo_cp_begin(cp, cmd_len | (cmd_len - 2));
-   ilo_cp_write(cp, cmd);
+   ilo_cp_begin(cp, cmd_len);
+   ilo_cp_write(cp, cmd | (cmd_len - 2));
    ilo_cp_write(cp, sip);
    ilo_cp_end(cp);
 }




More information about the mesa-commit mailing list