Mesa (master): i965: Don't flag gather quirks for Gen8+
Chris Forbes
chrisf at kemper.freedesktop.org
Sat Dec 7 03:17:23 UTC 2013
Module: Mesa
Branch: master
Commit: a1ca5802401c384c1eadbf72cf910c65e377600c
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=a1ca5802401c384c1eadbf72cf910c65e377600c
Author: Chris Forbes <chrisf at ijw.co.nz>
Date: Fri Nov 29 22:04:58 2013 +1300
i965: Don't flag gather quirks for Gen8+
My understanding is that Broadwell retains the same SCS mechanism
that Haswell has, so even if the underlying issue with this format
is not fixed, the w/a will be applied in SCS rather than needing
shader code.
Signed-off-by: Chris Forbes <chrisf at ijw.co.nz>
Cc: Kenneth Graunke <kenneth at whitecape.org>
Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
---
src/mesa/drivers/dri/i965/brw_wm.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/src/mesa/drivers/dri/i965/brw_wm.c b/src/mesa/drivers/dri/i965/brw_wm.c
index a2ae73f..6739a91 100644
--- a/src/mesa/drivers/dri/i965/brw_wm.c
+++ b/src/mesa/drivers/dri/i965/brw_wm.c
@@ -353,7 +353,7 @@ brw_populate_sampler_prog_key_data(struct gl_context *ctx,
/* gather4's channel select for green from RG32F is broken;
* requires a shader w/a on IVB; fixable with just SCS on HSW. */
- if (brw->gen >= 7 && !brw->is_haswell && prog->UsesGather) {
+ if (brw->gen == 7 && !brw->is_haswell && prog->UsesGather) {
if (img->InternalFormat == GL_RG32F)
key->gather_channel_quirk_mask |= 1 << s;
}
More information about the mesa-commit
mailing list