Mesa (master): Use line number information from entire function expression

Ian Romanick idr at kemper.freedesktop.org
Fri Dec 20 17:04:39 UTC 2013


Module: Mesa
Branch: master
Commit: 23d294bb60be41e3876179e7b763a275902d1efd
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=23d294bb60be41e3876179e7b763a275902d1efd

Author: Kevin Rogovin <kevin.rogovin at intel.com>
Date:   Mon Dec  9 10:38:35 2013 +0200

Use line number information from entire function expression

This patch changes the error reporting behavior for incorrect function
invocation (triggered by match_function_by_name() unable to find a
matching function call) from using the line number information
associated to the function name term to using the line number
information of the entire function expression. Fixes bug #72264.

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=72264
Reviewed-by: Ian Romanick <ian.d.romanick at intel.com>
Cc: "10.0" <mesa-stable at lists.freedesktop.org>

---

 src/glsl/ast_function.cpp |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/glsl/ast_function.cpp b/src/glsl/ast_function.cpp
index 9dbc0d0..605ab8c 100644
--- a/src/glsl/ast_function.cpp
+++ b/src/glsl/ast_function.cpp
@@ -1656,7 +1656,7 @@ ast_function_expression::hir(exec_list *instructions,
    } else {
       const ast_expression *id = subexpressions[0];
       const char *func_name = id->primary_expression.identifier;
-      YYLTYPE loc = id->get_location();
+      YYLTYPE loc = get_location();
       exec_list actual_parameters;
 
       process_parameters(instructions, &actual_parameters, &this->expressions,




More information about the mesa-commit mailing list