Mesa (master): i965: Fix 3DSTATE_PUSH_CONSTANT_ALLOC_PS packet creation.

Kenneth Graunke kwg at kemper.freedesktop.org
Fri Dec 20 20:25:46 UTC 2013


Module: Mesa
Branch: master
Commit: 51c9cfc296318760aab421a79da727acd0e36311
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=51c9cfc296318760aab421a79da727acd0e36311

Author: Kenneth Graunke <kenneth at whitecape.org>
Date:   Wed Dec 18 12:30:06 2013 -0800

i965: Fix 3DSTATE_PUSH_CONSTANT_ALLOC_PS packet creation.

When adding geometry shader support, we accidentally reversed the size
and offset parameters.

Signed-off-by: Kenneth Graunke <kenneth at whitecape.org>
Reviewed-by: Paul Berry <stereotype441 at gmail.com>
Cc: "10.0" <mesa-stable at lists.freedesktop.org>

---

 src/mesa/drivers/dri/i965/gen7_urb.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/mesa/drivers/dri/i965/gen7_urb.c b/src/mesa/drivers/dri/i965/gen7_urb.c
index c638586..3463476 100644
--- a/src/mesa/drivers/dri/i965/gen7_urb.c
+++ b/src/mesa/drivers/dri/i965/gen7_urb.c
@@ -112,7 +112,7 @@ gen7_emit_push_constant_state(struct brw_context *brw, unsigned vs_size,
    offset += gs_size;
 
    OUT_BATCH(_3DSTATE_PUSH_CONSTANT_ALLOC_PS << 16 | (2 - 2));
-   OUT_BATCH(offset | fs_size << GEN7_PUSH_CONSTANT_BUFFER_OFFSET_SHIFT);
+   OUT_BATCH(fs_size | offset << GEN7_PUSH_CONSTANT_BUFFER_OFFSET_SHIFT);
    ADVANCE_BATCH();
 
    /* From p292 of the Ivy Bridge PRM (11.2.4 3DSTATE_PUSH_CONSTANT_ALLOC_PS):




More information about the mesa-commit mailing list