Mesa (master): i965: Remove _NEW_DEPTH state flagging on drawbuffers change .

Eric Anholt anholt at kemper.freedesktop.org
Wed Jun 26 02:21:07 UTC 2013


Module: Mesa
Branch: master
Commit: 15c47481ba9bfaf88f125f12234da642588f1495
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=15c47481ba9bfaf88f125f12234da642588f1495

Author: Eric Anholt <eric at anholt.net>
Date:   Thu Jun 20 09:28:53 2013 -0700

i965: Remove _NEW_DEPTH state flagging on drawbuffers change.

Of the places noting a _NEW_DEPTH dependency, all were already checking
for _NEW_BUFFERS if appropriate.

Reviewed-by: Anuj Phogat <anuj.phogat at gmail.com>
Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>

---

 src/mesa/drivers/dri/i965/brw_vtbl.c        |    2 --
 src/mesa/drivers/dri/i965/gen7_misc_state.c |    2 +-
 2 files changed, 1 insertions(+), 3 deletions(-)

diff --git a/src/mesa/drivers/dri/i965/brw_vtbl.c b/src/mesa/drivers/dri/i965/brw_vtbl.c
index 2c71c08..99d661f 100644
--- a/src/mesa/drivers/dri/i965/brw_vtbl.c
+++ b/src/mesa/drivers/dri/i965/brw_vtbl.c
@@ -130,8 +130,6 @@ brw_update_draw_buffer(struct intel_context *intel)
       return;
    }
 
-   intel->NewGLState |= _NEW_DEPTH;
-
    /* The driver uses this in places that need to look up
     * renderbuffers' buffer objects.
     */
diff --git a/src/mesa/drivers/dri/i965/gen7_misc_state.c b/src/mesa/drivers/dri/i965/gen7_misc_state.c
index 12b752c..539fc32 100644
--- a/src/mesa/drivers/dri/i965/gen7_misc_state.c
+++ b/src/mesa/drivers/dri/i965/gen7_misc_state.c
@@ -44,7 +44,7 @@ gen7_emit_depth_stencil_hiz(struct brw_context *brw,
 
    intel_emit_depth_stall_flushes(intel);
 
-   /* _NEW_DEPTH, _NEW_STENCIL */
+   /* _NEW_DEPTH, _NEW_STENCIL, _NEW_BUFFERS */
    BEGIN_BATCH(7);
    OUT_BATCH(GEN7_3DSTATE_DEPTH_BUFFER << 16 | (7 - 2));
    OUT_BATCH((depth_mt ? depth_mt->region->pitch - 1 : 0) |




More information about the mesa-commit mailing list