Mesa (master): i965: Don't fill buffer with zeroes.

Kenneth Graunke kwg at kemper.freedesktop.org
Wed Mar 6 16:32:37 UTC 2013


Module: Mesa
Branch: master
Commit: 492693c0a5d653b95ab4a970fdc5bba074050243
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=492693c0a5d653b95ab4a970fdc5bba074050243

Author: Kenneth Graunke <kenneth at whitecape.org>
Date:   Mon Mar  4 11:38:28 2013 -0800

i965: Don't fill buffer with zeroes.

This was only necessary because our bounds checking was off by one, and
thus we read an extra pair of values.

Signed-off-by: Kenneth Graunke <kenneth at whitecape.org>
Reviewed-by: Eric Anholt <eric at anholt.net>

---

 src/mesa/drivers/dri/i965/brw_queryobj.c |    6 ------
 1 files changed, 0 insertions(+), 6 deletions(-)

diff --git a/src/mesa/drivers/dri/i965/brw_queryobj.c b/src/mesa/drivers/dri/i965/brw_queryobj.c
index a45435e..194725c 100644
--- a/src/mesa/drivers/dri/i965/brw_queryobj.c
+++ b/src/mesa/drivers/dri/i965/brw_queryobj.c
@@ -510,12 +510,6 @@ ensure_bo_has_space(struct gl_context *ctx, struct brw_query_object *query)
       }
 
       query->bo = drm_intel_bo_alloc(intel->bufmgr, "query", 4096, 1);
-
-      /* Fill the buffer with zeroes.  This is probably superfluous. */
-      drm_intel_bo_map(query->bo, true);
-      memset((char *) query->bo->virtual, 0, 4096);
-      drm_intel_bo_unmap(query->bo);
-
       query->last_index = 0;
    }
 }




More information about the mesa-commit mailing list