Mesa (master): i965: Don' t print a fatal-looking message if intelCreateContext fails.

Kenneth Graunke kwg at kemper.freedesktop.org
Wed Mar 20 17:40:49 UTC 2013


Module: Mesa
Branch: master
Commit: 2dd22130cd708bad4d6ae4acb706394b1dd6ecd9
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=2dd22130cd708bad4d6ae4acb706394b1dd6ecd9

Author: Kenneth Graunke <kenneth at whitecape.org>
Date:   Thu Mar 14 11:48:36 2013 -0700

i965: Don't print a fatal-looking message if intelCreateContext fails.

With the old context creation mechanism, an application asked the GL to
give it a context.  Failing to produce a context was a fatal error.

Now, with GLX_ARB_create_context, the application can request a specific
version.  If it's higher than the maximum version we support, context
creation will fail.  But this is a normal error that applications
recover from.

In particular, the new glxinfo tries to create OpenGL 4.3, 4.2, 4.1,
4.0, 3.3, and 3.2 contexts before finally succeeding at creating a 3.1
context.  This led to it printing the following message 6 times:
"brwCreateContext: failed to init intel context"

There's no need to alarm users (and developers) with such a message.

Signed-off-by: Kenneth Graunke <kenneth at whitecape.org>
Reviewed-by: Eric Anholt <eric at anholt.net>

---

 src/mesa/drivers/dri/i965/brw_context.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/src/mesa/drivers/dri/i965/brw_context.c b/src/mesa/drivers/dri/i965/brw_context.c
index fdbe327..72378bc 100644
--- a/src/mesa/drivers/dri/i965/brw_context.c
+++ b/src/mesa/drivers/dri/i965/brw_context.c
@@ -138,7 +138,6 @@ brwCreateContext(int api,
                           mesaVis, driContextPriv,
 			  sharedContextPrivate, &functions,
 			  error)) {
-      printf("%s: failed to init intel context\n", __FUNCTION__);
       ralloc_free(brw);
       return false;
    }




More information about the mesa-commit mailing list