Mesa (master): st/mesa: generate GL_OUT_OF_MEMORY if we can' t create the index buffer

Brian Paul brianp at kemper.freedesktop.org
Thu May 9 13:59:13 UTC 2013


Module: Mesa
Branch: master
Commit: e0144019c08cec64edb78c4f01d78bfbc2aa2edd
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=e0144019c08cec64edb78c4f01d78bfbc2aa2edd

Author: Brian Paul <brianp at vmware.com>
Date:   Wed May  8 10:18:49 2013 -0600

st/mesa: generate GL_OUT_OF_MEMORY if we can't create the index buffer

Before, if we failed to allocate the index buffer we'd silently
return from st_draw_vbo() without drawing anything.  We should
raise GL_OUT_OF_MEMORY to give some indication that something went
wrong.

Note: This is a candidate for the stable branches.

Reviewed-by: Marek Olšák <maraeo at gmail.com>

---

 src/mesa/state_tracker/st_draw.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/src/mesa/state_tracker/st_draw.c b/src/mesa/state_tracker/st_draw.c
index 437d554..a0cf2ca 100644
--- a/src/mesa/state_tracker/st_draw.c
+++ b/src/mesa/state_tracker/st_draw.c
@@ -230,7 +230,7 @@ st_draw_vbo(struct gl_context *ctx,
                                    nr_prims);
 
       if (!setup_index_buffer(st, ib, &ibuffer)) {
-         /* out of memory */
+         _mesa_error(ctx, GL_OUT_OF_MEMORY, "glBegin/DrawElements/DrawArray");
          return;
       }
 




More information about the mesa-commit mailing list