Mesa (9.1): i965/fs: Remove creation of a MOV instruction that's never used .

Ian Romanick idr at kemper.freedesktop.org
Fri May 10 20:43:46 UTC 2013


Module: Mesa
Branch: 9.1
Commit: d61b1fdad6ad4168f55eea335a5174e3318b76aa
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=d61b1fdad6ad4168f55eea335a5174e3318b76aa

Author: Eric Anholt <eric at anholt.net>
Date:   Wed Mar 13 12:17:25 2013 -0700

i965/fs: Remove creation of a MOV instruction that's never used.

We weren't inserting it into the list, so it did nothing.  This line was
replaced by the MOV/MUL block above.

NOTE: This is a candidate for the 9.1 branch.
Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
(cherry picked from commit 59e858861caad2649f4c282eb277a7fc6202ab65)

---

 src/mesa/drivers/dri/i965/brw_fs.cpp |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp b/src/mesa/drivers/dri/i965/brw_fs.cpp
index c4d78e9..9bd8dde 100644
--- a/src/mesa/drivers/dri/i965/brw_fs.cpp
+++ b/src/mesa/drivers/dri/i965/brw_fs.cpp
@@ -245,7 +245,6 @@ fs_visitor::VARYING_PULL_CONSTANT_LOAD(fs_reg dst, fs_reg surf_index,
       } else {
          instructions.push_tail(MUL(mrf, offset, fs_reg(4)));
       }
-      inst = MOV(mrf, offset);
       inst = new(mem_ctx) fs_inst(FS_OPCODE_VARYING_PULL_CONSTANT_LOAD,
                                   dst, surf_index);
       inst->header_present = header_present;




More information about the mesa-commit mailing list