Mesa (master): glsl: Remove some stale comments about ir_call

Ian Romanick idr at kemper.freedesktop.org
Mon May 13 19:06:53 UTC 2013


Module: Mesa
Branch: master
Commit: d13fbeea9634b5e3cae0213cc61706ffc316b64f
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=d13fbeea9634b5e3cae0213cc61706ffc316b64f

Author: Ian Romanick <ian.d.romanick at intel.com>
Date:   Wed May  8 10:59:47 2013 -0700

glsl: Remove some stale comments about ir_call

ir_call was changed long ago to be a statement rather than an
expression.  That makes this comment no longer valid.

Signed-off-by: Ian Romanick <ian.d.romanick at intel.com>
Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
Reviewed-by: Paul Berry <stereotype441 at gmail.com>

---

 src/glsl/lower_clip_distance.cpp |    8 ++------
 1 files changed, 2 insertions(+), 6 deletions(-)

diff --git a/src/glsl/lower_clip_distance.cpp b/src/glsl/lower_clip_distance.cpp
index 2ba0052..129375d 100644
--- a/src/glsl/lower_clip_distance.cpp
+++ b/src/glsl/lower_clip_distance.cpp
@@ -226,12 +226,8 @@ lower_clip_distance_visitor::visit_leave(ir_assignment *ir)
        * each of them.
        *
        * Note: to unroll into element-by-element assignments, we need to make
-       * clones of the LHS and RHS.  This is only safe if the LHS and RHS are
-       * side-effect free.  Fortunately, we know that they are, because the
-       * only kind of rvalue that can have side effects is an ir_call, and
-       * ir_calls only appear (a) as a statement on their own, or (b) as the
-       * RHS of an assignment that stores the result of the call in a
-       * temporary variable.
+       * clones of the LHS and RHS.  This is safe because expressions and
+       * l-values are side-effect free.
        */
       void *ctx = ralloc_parent(ir);
       int array_size = this->old_clip_distance_var->type->array_size();




More information about the mesa-commit mailing list