Mesa (master): ilo: no writeback without PIPE_TRANSFER_WRITE

Chia-I Wu olv at kemper.freedesktop.org
Wed May 15 07:28:00 UTC 2013


Module: Mesa
Branch: master
Commit: 5af8641ce0d1d725d5eb1df83c8211d2cdbe528c
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=5af8641ce0d1d725d5eb1df83c8211d2cdbe528c

Author: Chia-I Wu <olvaffe at gmail.com>
Date:   Wed May 15 08:50:34 2013 +0800

ilo: no writeback without PIPE_TRANSFER_WRITE

We should not write staging data back when PIPE_TRANSFER_WRITE is not set.

---

 src/gallium/drivers/ilo/ilo_transfer.c |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)

diff --git a/src/gallium/drivers/ilo/ilo_transfer.c b/src/gallium/drivers/ilo/ilo_transfer.c
index 3b4a213..3d38fe8 100644
--- a/src/gallium/drivers/ilo/ilo_transfer.c
+++ b/src/gallium/drivers/ilo/ilo_transfer.c
@@ -188,6 +188,11 @@ tex_staging_sys_unmap(struct ilo_context *ilo,
    struct pipe_transfer *dst_xfer;
    void *dst;
 
+   if (!(xfer->base.usage & PIPE_TRANSFER_WRITE)) {
+      FREE(xfer->staging_sys);
+      return;
+   }
+
    dst = ilo->base.transfer_map(&ilo->base,
          xfer->base.resource, xfer->base.level,
          PIPE_TRANSFER_WRITE |




More information about the mesa-commit mailing list