Mesa (master): glx: change query_renderer_integer() value param to unsigned
Brian Paul
brianp at kemper.freedesktop.org
Mon Nov 11 15:11:59 UTC 2013
Module: Mesa
Branch: master
Commit: 75982a5df42cd2406e529b7c96b36d2a8b1f7b60
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=75982a5df42cd2406e529b7c96b36d2a8b1f7b60
Author: Brian Paul <brianp at vmware.com>
Date: Fri Nov 8 09:00:46 2013 -0700
glx: change query_renderer_integer() value param to unsigned
When this function was added, the returned value was signed in some
places, unsigned in others.
v2: also add unsigned in the unit test, per Ian.
Reviewed-by: Ian Romanick <ian.d.romanick at intel.com>
---
src/glx/glxclient.h | 2 +-
src/glx/query_renderer.c | 2 +-
src/glx/tests/query_renderer_unittest.cpp | 3 ++-
3 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/src/glx/glxclient.h b/src/glx/glxclient.h
index e26a83e..e33dba6 100644
--- a/src/glx/glxclient.h
+++ b/src/glx/glxclient.h
@@ -477,7 +477,7 @@ struct glx_screen_vtable {
unsigned *error);
int (*query_renderer_integer)(struct glx_screen *psc,
int attribute,
- int *value);
+ unsigned int *value);
int (*query_renderer_string)(struct glx_screen *psc,
int attribute,
const char **value);
diff --git a/src/glx/query_renderer.c b/src/glx/query_renderer.c
index 981a844..9108ec2 100644
--- a/src/glx/query_renderer.c
+++ b/src/glx/query_renderer.c
@@ -30,7 +30,7 @@ __glXQueryRendererInteger(struct glx_screen *psc, int attribute,
unsigned int *value)
{
unsigned int values_for_query = 0;
- int buffer[32];
+ unsigned int buffer[32];
int err;
/* This probably means the caller is trying to use an extension function
diff --git a/src/glx/tests/query_renderer_unittest.cpp b/src/glx/tests/query_renderer_unittest.cpp
index f0998b7..2f3c4ef 100644
--- a/src/glx/tests/query_renderer_unittest.cpp
+++ b/src/glx/tests/query_renderer_unittest.cpp
@@ -56,7 +56,8 @@ static bool query_renderer_string_called = false;
static bool query_renderer_integer_called = false;
static int
-fake_query_renderer_integer(struct glx_screen *psc, int attribute, int *value)
+fake_query_renderer_integer(struct glx_screen *psc, int attribute,
+ unsigned int *value)
{
(void) psc;
(void) attribute;
More information about the mesa-commit
mailing list