Mesa (master): i965: Add a warning if something ever hits a bug I noticed.
Eric Anholt
anholt at kemper.freedesktop.org
Tue Nov 12 23:21:09 UTC 2013
Module: Mesa
Branch: master
Commit: 8bd45a7e7ed8be3f5bb13689d249fc886cf73067
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=8bd45a7e7ed8be3f5bb13689d249fc886cf73067
Author: Eric Anholt <eric at anholt.net>
Date: Thu Oct 31 10:14:17 2013 -0700
i965: Add a warning if something ever hits a bug I noticed.
We'd have to map the VBO and rewrite things to a lower stride to fix it.
Reviewed-by: Matt Turner <mattst88 at gmail.com>
---
src/mesa/drivers/dri/i965/brw_draw_upload.c | 4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/src/mesa/drivers/dri/i965/brw_draw_upload.c b/src/mesa/drivers/dri/i965/brw_draw_upload.c
index e2002e8..57b81df 100644
--- a/src/mesa/drivers/dri/i965/brw_draw_upload.c
+++ b/src/mesa/drivers/dri/i965/brw_draw_upload.c
@@ -609,6 +609,7 @@ static void brw_prepare_vertices(struct brw_context *brw)
static void brw_emit_vertices(struct brw_context *brw)
{
+ struct gl_context *ctx = &brw->ctx;
GLuint i, nr_elements;
brw_prepare_vertices(brw);
@@ -680,6 +681,9 @@ static void brw_emit_vertices(struct brw_context *brw)
if (brw->gen == 7)
dw0 |= GEN7_MOCS_L3 << 16;
+ WARN_ONCE(buffer->stride >= (brw->gen >= 5 ? 2048 : 2047),
+ "VBO stride %d too large, bad rendering may occur\n",
+ buffer->stride);
OUT_BATCH(dw0 | (buffer->stride << BRW_VB0_PITCH_SHIFT));
OUT_RELOC(buffer->bo, I915_GEM_DOMAIN_VERTEX, 0, buffer->offset);
if (brw->gen >= 5) {
More information about the mesa-commit
mailing list