Mesa (master): i915: Fix memory leak in do_blit_readpixels.

Vinson Lee vlee at kemper.freedesktop.org
Tue Oct 1 05:09:00 UTC 2013


Module: Mesa
Branch: master
Commit: eb0a57acaa7026b3212742a30f4ada3271d95616
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=eb0a57acaa7026b3212742a30f4ada3271d95616

Author: Vinson Lee <vlee at freedesktop.org>
Date:   Fri Sep 27 22:11:17 2013 -0700

i915: Fix memory leak in do_blit_readpixels.

Fixes "Resource leak" defect reported by Coverity.

Signed-off-by: Vinson Lee <vlee at freedesktop.org>
Reviewed-by: Eric Anholt <eric at anholt.net>

---

 src/mesa/drivers/dri/i915/intel_pixel_read.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/src/mesa/drivers/dri/i915/intel_pixel_read.c b/src/mesa/drivers/dri/i915/intel_pixel_read.c
index 26eb496..8fd1c8d 100644
--- a/src/mesa/drivers/dri/i915/intel_pixel_read.c
+++ b/src/mesa/drivers/dri/i915/intel_pixel_read.c
@@ -148,6 +148,7 @@ do_blit_readpixels(struct gl_context * ctx,
                            pbo_mt, 0, 0,
                            0, 0, dst_flip,
                            width, height, GL_COPY)) {
+      intel_miptree_release(&pbo_mt);
       return false;
    }
 




More information about the mesa-commit mailing list