Mesa (master): i965: Switch fs_inst to the non-zeroing allocator.

Francisco Jerez currojerez at kemper.freedesktop.org
Wed Oct 2 00:42:34 UTC 2013


Module: Mesa
Branch: master
Commit: ced327ec64d37211ff77f17aac2338f26c82c67f
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=ced327ec64d37211ff77f17aac2338f26c82c67f

Author: Francisco Jerez <currojerez at riseup.net>
Date:   Fri Sep 20 16:33:55 2013 -0700

i965: Switch fs_inst to the non-zeroing allocator.

All member variables of fs_inst are already being initialized from its
constructor, it's not necessary to use rzalloc to allocate its memory,
and doing so makes it more likely that we will start relying on the
allocator to zero out all memory if the class is ever extended with
new member variables.

That's bad because it ties objects to some specific allocation scheme,
and gives unpredictable results when an object is created with a
different allocator -- Stack allocation, array allocation, or
aggregation inside a different object are some of the useful
possibilities that come to my mind.

Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>

---

 src/mesa/drivers/dri/i965/brw_fs.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/src/mesa/drivers/dri/i965/brw_fs.h b/src/mesa/drivers/dri/i965/brw_fs.h
index 8d35112..6d93132 100644
--- a/src/mesa/drivers/dri/i965/brw_fs.h
+++ b/src/mesa/drivers/dri/i965/brw_fs.h
@@ -124,7 +124,7 @@ public:
 
 class fs_inst : public backend_instruction {
 public:
-   DECLARE_RZALLOC_CXX_OPERATORS(fs_inst)
+   DECLARE_RALLOC_CXX_OPERATORS(fs_inst)
 
    void init();
 




More information about the mesa-commit mailing list