Mesa (master): glsl: Construct gl_in with a location of -1.

Paul Berry stereotype441 at kemper.freedesktop.org
Thu Oct 10 21:46:57 UTC 2013


Module: Mesa
Branch: master
Commit: 192d05f2770797db61d30a06f2e07602575a9791
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=192d05f2770797db61d30a06f2e07602575a9791

Author: Paul Berry <stereotype441 at gmail.com>
Date:   Sun Sep 29 08:19:13 2013 -0700

glsl: Construct gl_in with a location of -1.

We use a location of -1 for variables which don't have their own
assigned locations--this includes ir_variables which represent named
interface blocks.  Technically the location assigned to gl_in doesn't
matter, since gl_in is only accessed via its members (which have their
own locations).  But it's nice to be consistent.

Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
Reviewed-by: Jordan Justen <jordan.l.justen at intel.com>
Reviewed-by: Ian Romanick <ian.d.romanick at intel.com>

---

 src/glsl/builtin_variables.cpp |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/src/glsl/builtin_variables.cpp b/src/glsl/builtin_variables.cpp
index 7a64acc..6fc9183 100644
--- a/src/glsl/builtin_variables.cpp
+++ b/src/glsl/builtin_variables.cpp
@@ -830,7 +830,7 @@ builtin_variable_generator::generate_varyings()
                                            GLSL_INTERFACE_PACKING_STD140,
                                            "gl_in");
       ir_variable *var = add_variable("gl_in", array(per_vertex_type, 0),
-                                      ir_var_shader_in, 0);
+                                      ir_var_shader_in, -1);
       var->init_interface_type(per_vertex_type);
    }
 }




More information about the mesa-commit mailing list