Mesa (master): glsl/tests: Verify fragment shader built-ins generated by _mesa_glsl_initialize_variables
Ian Romanick
idr at kemper.freedesktop.org
Tue Oct 22 22:23:43 UTC 2013
Module: Mesa
Branch: master
Commit: f094a0f825abd261109ee566a760089dd4da64e6
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=f094a0f825abd261109ee566a760089dd4da64e6
Author: Ian Romanick <ian.d.romanick at intel.com>
Date: Thu Oct 3 15:14:35 2013 -0700
glsl/tests: Verify fragment shader built-ins generated by _mesa_glsl_initialize_variables
Checks that the variables generated meet certain criteria.
- Fragment shader inputs have an explicit location.
- Fragment shader outputs have an explicit location.
- Vertex / geometry shader-only varying locations are not used.
- Fragment shader uniforms and system values don't have an explicit
location.
- Fragment shader constants don't have an explicit location and are
read-only.
- No other kinds of fragment variables exist.
It does not verify that an specific variables exist.
v2: Use _mesa_varying_slot_in_fs in
fragment_builtin.inputs_have_explicit_location. Suggested by Paul.
Signed-off-by: Ian Romanick <ian.d.romanick at intel.com>
Reviewed-by: Paul Berry <stereotype441 at gmail.com>
---
src/glsl/tests/builtin_variable_test.cpp | 71 ++++++++++++++++++++++++++++++
1 files changed, 71 insertions(+), 0 deletions(-)
diff --git a/src/glsl/tests/builtin_variable_test.cpp b/src/glsl/tests/builtin_variable_test.cpp
index af0ba1e..4dbccdc 100644
--- a/src/glsl/tests/builtin_variable_test.cpp
+++ b/src/glsl/tests/builtin_variable_test.cpp
@@ -222,3 +222,74 @@ TEST_F(vertex_builtin, no_invalid_variable_modes)
{
common_builtin::no_invalid_variable_modes();
}
+
+/********************************************************************/
+
+class fragment_builtin : public common_builtin {
+public:
+ fragment_builtin()
+ : common_builtin(GL_FRAGMENT_SHADER)
+ {
+ /* empty */
+ }
+};
+
+TEST_F(fragment_builtin, names_start_with_gl)
+{
+ common_builtin::names_start_with_gl();
+}
+
+TEST_F(fragment_builtin, inputs_have_explicit_location)
+{
+ foreach_list(node, &this->ir) {
+ ir_variable *const var = ((ir_instruction *) node)->as_variable();
+
+ if (var->mode != ir_var_shader_in)
+ continue;
+
+ EXPECT_TRUE(var->explicit_location);
+ EXPECT_NE(-1, var->location);
+ EXPECT_GT(VARYING_SLOT_VAR0, var->location);
+ EXPECT_EQ(0u, var->location_frac);
+
+ /* Several varyings only exist in the vertex / geometry shader. Be sure
+ * that no inputs with these locations exist.
+ */
+ EXPECT_TRUE(_mesa_varying_slot_in_fs((gl_varying_slot) var->location));
+ }
+}
+
+TEST_F(fragment_builtin, outputs_have_explicit_location)
+{
+ foreach_list(node, &this->ir) {
+ ir_variable *const var = ((ir_instruction *) node)->as_variable();
+
+ if (var->mode != ir_var_shader_out)
+ continue;
+
+ EXPECT_TRUE(var->explicit_location);
+ EXPECT_NE(-1, var->location);
+
+ /* gl_FragData[] has location FRAG_RESULT_DATA0. Locations beyond that
+ * are invalid.
+ */
+ EXPECT_GE(FRAG_RESULT_DATA0, var->location);
+
+ EXPECT_EQ(0u, var->location_frac);
+ }
+}
+
+TEST_F(fragment_builtin, uniforms_and_system_values_dont_have_explicit_location)
+{
+ common_builtin::uniforms_and_system_values_dont_have_explicit_location();
+}
+
+TEST_F(fragment_builtin, constants_are_constant)
+{
+ common_builtin::constants_are_constant();
+}
+
+TEST_F(fragment_builtin, no_invalid_variable_modes)
+{
+ common_builtin::no_invalid_variable_modes();
+}
More information about the mesa-commit
mailing list