Mesa (master): glsl: Drop no-op shifts involving 0.

Eric Anholt anholt at kemper.freedesktop.org
Mon Oct 28 21:16:43 UTC 2013


Module: Mesa
Branch: master
Commit: 08bf52712e9dbd32ea3e4855c3446eba624fc890
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=08bf52712e9dbd32ea3e4855c3446eba624fc890

Author: Eric Anholt <eric at anholt.net>
Date:   Mon Oct 21 17:01:49 2013 -0700

glsl: Drop no-op shifts involving 0.

I noticed this in a shader in Unigine Heaven that was spilling.  While it
doesn't really reduce register pressure, it shaves a few instructions
anyway (7955 -> 7882).

v2: Fix turning "0 >> x" into "x" instead of "0" (caught by Erik
    Faye-Lund).

Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
Reviewed-by: Matt Turner <mattst88 at gmail.com>

---

 src/glsl/opt_algebraic.cpp |   10 ++++++++++
 1 files changed, 10 insertions(+), 0 deletions(-)

diff --git a/src/glsl/opt_algebraic.cpp b/src/glsl/opt_algebraic.cpp
index 2e33dfe..a07e153 100644
--- a/src/glsl/opt_algebraic.cpp
+++ b/src/glsl/opt_algebraic.cpp
@@ -346,6 +346,16 @@ ir_algebraic_visitor::handle_expression(ir_expression *ir)
       }
       break;
 
+   case ir_binop_rshift:
+   case ir_binop_lshift:
+      /* 0 >> x == 0 */
+      if (is_vec_zero(op_const[0]))
+         return ir->operands[0];
+      /* x >> 0 == x */
+      if (is_vec_zero(op_const[1]))
+         return ir->operands[0];
+      break;
+
    case ir_binop_logic_and:
       /* FINISHME: Also simplify (a && a) to (a). */
       if (is_vec_one(op_const[0])) {




More information about the mesa-commit mailing list