Mesa (master): i915g: Fix initial array index

Stephane Marchesin marcheu at kemper.freedesktop.org
Fri Sep 6 18:07:43 UTC 2013


Module: Mesa
Branch: master
Commit: 7125af295751c504063644f61f19c0d70a6b1b3e
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=7125af295751c504063644f61f19c0d70a6b1b3e

Author: Stéphane Marchesin <marcheu at chromium.org>
Date:   Fri Sep  6 10:45:27 2013 -0700

i915g: Fix initial array index

Fixes "Out-of-bounds read" defect reported by Coverity.

---

 src/gallium/drivers/i915/i915_state_emit.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/src/gallium/drivers/i915/i915_state_emit.c b/src/gallium/drivers/i915/i915_state_emit.c
index 9c16e59..71ac326 100644
--- a/src/gallium/drivers/i915/i915_state_emit.c
+++ b/src/gallium/drivers/i915/i915_state_emit.c
@@ -142,7 +142,7 @@ static uint target_fixup(struct pipe_surface *p, int component)
       { PIPE_FORMAT_A8_UNORM,       { 0, 0, 0, S5_WRITEDISABLE_RED | S5_WRITEDISABLE_GREEN | S5_WRITEDISABLE_BLUE | S5_WRITEDISABLE_ALPHA}},
       { 0,                          { S5_WRITEDISABLE_RED, S5_WRITEDISABLE_GREEN, S5_WRITEDISABLE_BLUE, S5_WRITEDISABLE_ALPHA}}
    };
-   int i = sizeof(fixup_mask) / sizeof(*fixup_mask);
+   int i = sizeof(fixup_mask) / sizeof(*fixup_mask) - 1;
 
    if (p)
       for(i = 0; fixup_mask[i].format != 0; i++)




More information about the mesa-commit mailing list