Mesa (master): glsl: Add missing va_end in builtin_builder::add_function.

Vinson Lee vlee at kemper.freedesktop.org
Tue Sep 10 16:52:15 UTC 2013


Module: Mesa
Branch: master
Commit: 787ac4207e30a18b4286faa2140d06b6fb8daf36
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=787ac4207e30a18b4286faa2140d06b6fb8daf36

Author: Vinson Lee <vlee at freedesktop.org>
Date:   Mon Sep  9 20:25:55 2013 -0700

glsl: Add missing va_end in builtin_builder::add_function.

Fixes "Missing varargs init or cleanup" defect reported by Coverity.

Signed-off-by: Vinson Lee <vlee at freedesktop.org>
Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>

---

 src/glsl/builtin_functions.cpp |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/src/glsl/builtin_functions.cpp b/src/glsl/builtin_functions.cpp
index 1fedca4..ce78df1 100644
--- a/src/glsl/builtin_functions.cpp
+++ b/src/glsl/builtin_functions.cpp
@@ -1853,6 +1853,7 @@ builtin_builder::add_function(const char *name, ...)
 
       f->add_signature(sig);
    }
+   va_end(ap);
 
    shader->symbols->add_function(f);
 }




More information about the mesa-commit mailing list