Mesa (master): freedreno/a3xx: fix VFD_INDEX_MAX overflow

Rob Clark robclark at kemper.freedesktop.org
Sat Sep 14 17:32:51 UTC 2013


Module: Mesa
Branch: master
Commit: d7be322410887b94fe1ddc37a6ae63ea20721467
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=d7be322410887b94fe1ddc37a6ae63ea20721467

Author: Rob Clark <robclark at freedesktop.org>
Date:   Wed Sep 11 10:06:29 2013 -0400

freedreno/a3xx: fix VFD_INDEX_MAX overflow

max_index may be 0xffffffff.  The hardware does not need 1 + max_index
(although it does not hurt unless max_index wraps around to zero).

Signed-off-by: Rob Clark <robclark at freedesktop.org>

---

 src/gallium/drivers/freedreno/a3xx/fd3_draw.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/src/gallium/drivers/freedreno/a3xx/fd3_draw.c b/src/gallium/drivers/freedreno/a3xx/fd3_draw.c
index e1f8067..85c7441 100644
--- a/src/gallium/drivers/freedreno/a3xx/fd3_draw.c
+++ b/src/gallium/drivers/freedreno/a3xx/fd3_draw.c
@@ -84,7 +84,7 @@ fd3_draw(struct fd_context *ctx, const struct pipe_draw_info *info)
 
 	OUT_PKT0(ring, REG_A3XX_VFD_INDEX_MIN, 4);
 	OUT_RING(ring, info->min_index);        /* VFD_INDEX_MIN */
-	OUT_RING(ring, info->max_index + 1);    /* VFD_INDEX_MAX */
+	OUT_RING(ring, info->max_index);        /* VFD_INDEX_MAX */
 	OUT_RING(ring, info->start_instance);   /* VFD_INSTANCEID_OFFSET */
 	OUT_RING(ring, info->start);            /* VFD_INDEX_OFFSET */
 




More information about the mesa-commit mailing list