Mesa (master): r600g/sb: Move variable dereference after null check.

Vinson Lee vlee at kemper.freedesktop.org
Mon Sep 30 17:28:09 UTC 2013


Module: Mesa
Branch: master
Commit: 114ae4747549b5677cca0dbd2b8c8531d8789c49
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=114ae4747549b5677cca0dbd2b8c8531d8789c49

Author: Vinson Lee <vlee at freedesktop.org>
Date:   Fri Sep 27 23:05:54 2013 -0700

r600g/sb: Move variable dereference after null check.

Fixes "Deference before null check" defect reported by Coverity.

Signed-off-by: Vinson Lee <vlee at freedesktop.org>
Reviewed-by: Vadim Girlin <vadimgirlin at gmail.com>

---

 src/gallium/drivers/r600/sb/sb_ra_init.cpp |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/src/gallium/drivers/r600/sb/sb_ra_init.cpp b/src/gallium/drivers/r600/sb/sb_ra_init.cpp
index 0b332a9..e53aba5 100644
--- a/src/gallium/drivers/r600/sb/sb_ra_init.cpp
+++ b/src/gallium/drivers/r600/sb/sb_ra_init.cpp
@@ -395,11 +395,12 @@ void ra_init::color_bs_constraint(ra_constraint* c) {
 
 	for (vvec::iterator I = vv.begin(), E = vv.end(); I != E; ++I) {
 		value *v = *I;
-		sel_chan gpr = v->get_final_gpr();
 
 		if (!v || v->is_dead())
 			continue;
 
+		sel_chan gpr = v->get_final_gpr();
+
 		val_set interf;
 
 		if (v->chunk)




More information about the mesa-commit mailing list