Mesa (master): glsl: Allow explicit binding on atomics again
Kenneth Graunke
kwg at kemper.freedesktop.org
Fri Apr 18 17:34:25 UTC 2014
Module: Mesa
Branch: master
Commit: 92840aabf7a96583619a01a8257ef6f117f0ca50
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=92840aabf7a96583619a01a8257ef6f117f0ca50
Author: Chris Forbes <chrisf at ijw.co.nz>
Date: Sat Apr 12 19:44:46 2014 +1200
glsl: Allow explicit binding on atomics again
As of 943b2d52bf5, layout(binding) on an atomic would fail the assertion
here.
Signed-off-by: Chris Forbes <chrisf at ijw.co.nz>
Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
---
src/glsl/link_uniform_initializers.cpp | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/src/glsl/link_uniform_initializers.cpp b/src/glsl/link_uniform_initializers.cpp
index e60bb64..2100e05 100644
--- a/src/glsl/link_uniform_initializers.cpp
+++ b/src/glsl/link_uniform_initializers.cpp
@@ -296,8 +296,10 @@ link_set_uniform_initializers(struct gl_shader_program *prog)
linker::set_block_binding(prog, iface_type->name,
var->data.binding);
}
+ } else if (type->contains_atomic()) {
+ /* we don't actually need to do anything. */
} else {
- assert(!"Explicit binding not on a sampler or UBO.");
+ assert(!"Explicit binding not on a sampler, UBO or atomic.");
}
} else if (var->constant_value) {
linker::set_uniform_initializer(mem_ctx, prog, var->name,
More information about the mesa-commit
mailing list