Mesa (master): i965/vec4: Switch to MOV, not OR, for GS_OPCODE_THREAD_END on Gen8.

Kenneth Graunke kwg at kemper.freedesktop.org
Tue Aug 12 20:53:38 UTC 2014


Module: Mesa
Branch: master
Commit: 17c17b87f9be5403f706f491756de1be26376308
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=17c17b87f9be5403f706f491756de1be26376308

Author: Kenneth Graunke <kenneth at whitecape.org>
Date:   Mon Aug 11 08:13:05 2014 -0700

i965/vec4: Switch to MOV, not OR, for GS_OPCODE_THREAD_END on Gen8.

Either should work.

Signed-off-by: Kenneth Graunke <kenneth at whitecape.org>
Reviewed-by: Chris Forbes <chrisf at ijw.co.nz>
Reviewed-by: Matt Turner <mattst88 at gmail.com>

---

 src/mesa/drivers/dri/i965/gen8_vec4_generator.cpp |    7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/src/mesa/drivers/dri/i965/gen8_vec4_generator.cpp b/src/mesa/drivers/dri/i965/gen8_vec4_generator.cpp
index bf904c6..cbac89d 100644
--- a/src/mesa/drivers/dri/i965/gen8_vec4_generator.cpp
+++ b/src/mesa/drivers/dri/i965/gen8_vec4_generator.cpp
@@ -202,10 +202,9 @@ gen8_vec4_generator::generate_gs_thread_end(vec4_instruction *ir)
 
    /* Enable Channel Masks in the URB_WRITE_HWORD message header */
    default_state.access_mode = BRW_ALIGN_1;
-   inst = OR(retype(brw_vec1_grf(GEN7_MRF_HACK_START + ir->base_mrf, 5),
-                    BRW_REGISTER_TYPE_UD),
-             retype(brw_vec1_grf(0, 5), BRW_REGISTER_TYPE_UD),
-             brw_imm_ud(0xff00)); /* could be 0x1100 but shouldn't matter */
+   inst = MOV(retype(brw_vec1_grf(GEN7_MRF_HACK_START + ir->base_mrf, 5),
+                     BRW_REGISTER_TYPE_UD),
+              brw_imm_ud(0xff00)); /* could be 0x1100 but shouldn't matter */
    gen8_set_mask_control(inst, BRW_MASK_DISABLE);
    default_state.access_mode = BRW_ALIGN_16;
 




More information about the mesa-commit mailing list