Mesa (master): glsl: Fixed vectorize pass vs. texture lookups.

Matt Turner mattst88 at kemper.freedesktop.org
Thu Aug 14 16:58:41 UTC 2014


Module: Mesa
Branch: master
Commit: 2b837576eb47eeb25f381c534a8bbccda0ee4c89
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=2b837576eb47eeb25f381c534a8bbccda0ee4c89

Author: Aras Pranckevicius <aras at unity3d.com>
Date:   Wed Aug 13 20:40:05 2014 +0300

glsl: Fixed vectorize pass vs. texture lookups.

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=82574
Reviewed-by: Matt Turner <mattst88 at gmail.com>

---

 src/glsl/opt_vectorize.cpp |   13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/src/glsl/opt_vectorize.cpp b/src/glsl/opt_vectorize.cpp
index 28534a8..2f71a83 100644
--- a/src/glsl/opt_vectorize.cpp
+++ b/src/glsl/opt_vectorize.cpp
@@ -86,6 +86,7 @@ public:
    virtual ir_visitor_status visit_enter(ir_expression *);
    virtual ir_visitor_status visit_enter(ir_if *);
    virtual ir_visitor_status visit_enter(ir_loop *);
+   virtual ir_visitor_status visit_enter(ir_texture *);
 
    virtual ir_visitor_status visit_leave(ir_assignment *);
 
@@ -352,6 +353,18 @@ ir_vectorize_visitor::visit_enter(ir_loop *ir)
 }
 
 /**
+ * Upon entering an ir_texture, remove the current assignment from
+ * further consideration. Vectorizing multiple texture lookups into one
+ * is wrong.
+ */
+ir_visitor_status
+ir_vectorize_visitor::visit_enter(ir_texture *)
+{
+   this->current_assignment = NULL;
+   return visit_continue_with_parent;
+}
+
+/**
  * Upon leaving an ir_assignment, save a pointer to it in ::assignment[] if
  * the swizzle mask(s) found were appropriate. Also save a pointer in
  * ::last_assignment so that we can compare future assignments with it.




More information about the mesa-commit mailing list