Mesa (master): vc4: Stop complaining about unknown texture channel types.

Eric Anholt anholt at kemper.freedesktop.org
Fri Aug 22 17:19:14 UTC 2014


Module: Mesa
Branch: master
Commit: 1cb5cfba8562c511625ba30f6277e8de52ea5c8a
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=1cb5cfba8562c511625ba30f6277e8de52ea5c8a

Author: Eric Anholt <eric at anholt.net>
Date:   Wed Aug 20 09:31:26 2014 -0700

vc4: Stop complaining about unknown texture channel types.

It doesn't matter to this code -- the sampler always returns 8-bit unorm
rgba.

---

 src/gallium/drivers/vc4/vc4_program.c |   10 ----------
 1 file changed, 10 deletions(-)

diff --git a/src/gallium/drivers/vc4/vc4_program.c b/src/gallium/drivers/vc4/vc4_program.c
index 8907cc6..fb1a2fe 100644
--- a/src/gallium/drivers/vc4/vc4_program.c
+++ b/src/gallium/drivers/vc4/vc4_program.c
@@ -368,7 +368,6 @@ tgsi_to_qir_tex(struct tgsi_to_qir *trans,
         for (int i = 0; i < 4; i++)
                 unpacked[i] = qir_R4_UNPACK(c, i);
 
-        bool format_warned = false;
         for (int i = 0; i < 4; i++) {
                 if (!(tgsi_inst->Dst[0].Register.WriteMask & (1 << i)))
                         continue;
@@ -378,15 +377,6 @@ tgsi_to_qir_tex(struct tgsi_to_qir *trans,
                         util_format_description(format);
 
                 uint8_t swiz = desc->swizzle[i];
-                if (!format_warned &&
-                    swiz <= UTIL_FORMAT_SWIZZLE_W &&
-                    (desc->channel[swiz].type != UTIL_FORMAT_TYPE_UNSIGNED ||
-                     desc->channel[swiz].size != 8)) {
-                        fprintf(stderr,
-                                "tex channel %d unsupported type: %s\n",
-                                i, util_format_name(format));
-                        format_warned = true;
-                }
 
                 update_dst(trans, tgsi_inst, i,
                            get_swizzled_channel(trans, unpacked, swiz));




More information about the mesa-commit mailing list