Mesa (master): i965/disasm: Disassemble JMPI's source properly.

Matt Turner mattst88 at kemper.freedesktop.org
Fri Aug 29 02:07:26 UTC 2014


Module: Mesa
Branch: master
Commit: fb2fddefce75078bf6b1a904a65efc46c9ee6088
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=fb2fddefce75078bf6b1a904a65efc46c9ee6088

Author: Matt Turner <mattst88 at gmail.com>
Date:   Sat Aug 23 23:59:30 2014 -0700

i965/disasm: Disassemble JMPI's source properly.

The source can be a register as well as an immediate, and disassembling
a register as an immediate can have some strange results.

Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>

---

 src/mesa/drivers/dri/i965/brw_disasm.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/mesa/drivers/dri/i965/brw_disasm.c b/src/mesa/drivers/dri/i965/brw_disasm.c
index b73ada8..4374278 100644
--- a/src/mesa/drivers/dri/i965/brw_disasm.c
+++ b/src/mesa/drivers/dri/i965/brw_disasm.c
@@ -1264,7 +1264,8 @@ brw_disassemble_inst(FILE *file, struct brw_context *brw, brw_inst *inst,
       pad(file, 16);
       format(file, "Pop: %d", brw_inst_gen4_pop_count(brw, inst));
    } else if (opcode == BRW_OPCODE_JMPI) {
-      format(file, " %d", brw_inst_imm_d(brw, inst));
+      pad(file, 16);
+      err |= src1(file, brw, inst);
    } else if (opcode_descs[opcode].nsrc == 3) {
       pad(file, 16);
       err |= dest_3src(file, brw, inst);




More information about the mesa-commit mailing list