Mesa (10.4): st/nine: remove unused pipe_viewport_state::translate[3] and scale[3]
Emil Velikov
evelikov at kemper.freedesktop.org
Wed Dec 3 23:44:47 UTC 2014
Module: Mesa
Branch: 10.4
Commit: cfbc474d8024662cc67f7da990d30711e89b68a3
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=cfbc474d8024662cc67f7da990d30711e89b68a3
Author: David Heidelberg <david at ixit.cz>
Date: Tue Nov 25 00:38:09 2014 +0100
st/nine: remove unused pipe_viewport_state::translate[3] and scale[3]
2efabd9f5a711a7f6cd1846630244b7814bf25b3 removed them as unused.
This caused random memory overwrites (reported by Coverity).
Cc: "10.4" <mesa-stable at lists.freedesktop.org>
Reviewed-by: Ilia Mirkin <imirkin at alum.mit.edu>
Reviewed-by: Marek Olšák <marek.olsak at amd.com>
Reviewed-by: Axel Davy <axel.davy at ens.fr>
Signed-off-by: David Heidelberg <david at ixit.cz>
(cherry picked from commit 90fea6b3e0153c12d8d1a0f817c56a3efa0ce99c)
---
src/gallium/state_trackers/nine/nine_state.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/src/gallium/state_trackers/nine/nine_state.c b/src/gallium/state_trackers/nine/nine_state.c
index 6924449..37de6a3 100644
--- a/src/gallium/state_trackers/nine/nine_state.c
+++ b/src/gallium/state_trackers/nine/nine_state.c
@@ -141,11 +141,9 @@ update_viewport(struct NineDevice9 *device)
pvport.scale[0] = (float)vport->Width * 0.5f;
pvport.scale[1] = (float)vport->Height * -0.5f;
pvport.scale[2] = vport->MaxZ - vport->MinZ;
- pvport.scale[3] = 1.0f;
pvport.translate[0] = (float)vport->Width * 0.5f + (float)vport->X;
pvport.translate[1] = (float)vport->Height * 0.5f + (float)vport->Y;
pvport.translate[2] = vport->MinZ;
- pvport.translate[3] = 0.0f;
pipe->set_viewport_states(pipe, 0, 1, &pvport);
}
More information about the mesa-commit
mailing list