Mesa (master): draw: fix another decompose bug affecting constant interpolated attributes
Roland Scheidegger
sroland at kemper.freedesktop.org
Wed Dec 10 21:11:33 UTC 2014
Module: Mesa
Branch: master
Commit: db3dfcfe90a3d27e6020e0d3642f8ab0330e57be
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=db3dfcfe90a3d27e6020e0d3642f8ab0330e57be
Author: Roland Scheidegger <sroland at vmware.com>
Date: Wed Dec 10 19:39:19 2014 +0100
draw: fix another decompose bug affecting constant interpolated attributes
Previously the first provoking vertex convention would only be used if
flatshading were enabled. No matter how I look at it that cannot be possibly
correct. Maybe the code getting used was somewhat simpler that way at a time
where there weren't constant interpolated attributes, only flatshading...
(Note that all other places including the decomposition macros already do
the same.)
Reviewed-by: Jose Fonseca <jfonseca at vmware.com>
---
src/gallium/auxiliary/draw/draw_pt_decompose.h | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/src/gallium/auxiliary/draw/draw_pt_decompose.h b/src/gallium/auxiliary/draw/draw_pt_decompose.h
index 8637085..0b2522c 100644
--- a/src/gallium/auxiliary/draw/draw_pt_decompose.h
+++ b/src/gallium/auxiliary/draw/draw_pt_decompose.h
@@ -3,7 +3,6 @@
const boolean quads_flatshade_last = \
draw->quads_always_flatshade_last; \
const boolean last_vertex_last = \
- !(draw->rasterizer->flatshade && \
- draw->rasterizer->flatshade_first);
+ !draw->rasterizer->flatshade_first;
#include "draw_decompose_tmp.h"
More information about the mesa-commit
mailing list