Mesa (master): i965: Fix S8 and X8 reversal in brw_depthbuffer_format refactor.
Kenneth Graunke
kwg at kemper.freedesktop.org
Sat Feb 22 03:15:52 UTC 2014
Module: Mesa
Branch: master
Commit: 82f9ad8c6011f5c1e8fd7065eeb6094f6e16dea9
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=82f9ad8c6011f5c1e8fd7065eeb6094f6e16dea9
Author: Kenneth Graunke <kenneth at whitecape.org>
Date: Thu Feb 20 23:08:22 2014 -0800
i965: Fix S8 and X8 reversal in brw_depthbuffer_format refactor.
In commit 09d9a8913e8c28fc4c1c60d7da85a2f093786894, I accidentally
botched the X8 and S8 cases. (I wrote this patch before realizing that
X8 and S8 had been swapped in the big MESA_FORMAT rename, and apparently
didn't rebase it properly after fixing that...)
Fixes regressions in 13 Piglit tests on Ironlake.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=75291
Signed-off-by: Kenneth Graunke <kenneth at whitecape.org>
Reviewed-by: Jordan Justen <jordan.l.justen at intel.com>
Reviewed-by: Ian Romanick <ian.d.romanick at intel.com>
---
src/mesa/drivers/dri/i965/brw_surface_formats.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/mesa/drivers/dri/i965/brw_surface_formats.c b/src/mesa/drivers/dri/i965/brw_surface_formats.c
index b2c36d9..9acece5 100644
--- a/src/mesa/drivers/dri/i965/brw_surface_formats.c
+++ b/src/mesa/drivers/dri/i965/brw_surface_formats.c
@@ -741,7 +741,7 @@ brw_depth_format(struct brw_context *brw, mesa_format format)
return BRW_DEPTHFORMAT_D16_UNORM;
case MESA_FORMAT_Z_FLOAT32:
return BRW_DEPTHFORMAT_D32_FLOAT;
- case MESA_FORMAT_Z24_UNORM_S8_UINT:
+ case MESA_FORMAT_Z24_UNORM_X8_UINT:
if (brw->gen >= 6) {
return BRW_DEPTHFORMAT_D24_UNORM_X8_UINT;
} else {
@@ -761,8 +761,8 @@ brw_depth_format(struct brw_context *brw, mesa_format format)
*/
return BRW_DEPTHFORMAT_D24_UNORM_S8_UINT;
}
- case MESA_FORMAT_Z24_UNORM_X8_UINT:
- return BRW_DEPTHFORMAT_D24_UNORM_X8_UINT;
+ case MESA_FORMAT_Z24_UNORM_S8_UINT:
+ return BRW_DEPTHFORMAT_D24_UNORM_S8_UINT;
case MESA_FORMAT_Z32_FLOAT_S8X24_UINT:
return BRW_DEPTHFORMAT_D32_FLOAT_S8X24_UINT;
default:
More information about the mesa-commit
mailing list