Mesa (master): glx: Fix the GLXFBConfig attrib sort priorities
Fredrik Höglund
fredrik at kemper.freedesktop.org
Wed Feb 26 01:21:21 UTC 2014
Module: Mesa
Branch: master
Commit: 3616e862f29838d73fcb05134b1dc628da499fc2
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=3616e862f29838d73fcb05134b1dc628da499fc2
Author: Fredrik Höglund <fredrik at kde.org>
Date: Sat Feb 15 18:48:40 2014 +0100
glx: Fix the GLXFBConfig attrib sort priorities
The sort priorites for GLX_SAMPLES and GLX_SAMPLE_BUFFERS are
not defined in GL_ARB_multisample, but they are defined in
the GLX 1.4 specification.
Cc: "9.2 10.0 10.1" <mesa-stable at lists.freedesktop.org>
Reviewed-by: Ian Romanick <ian.d.romanick at intel.com>
---
src/glx/glxcmds.c | 11 ++++-------
1 file changed, 4 insertions(+), 7 deletions(-)
diff --git a/src/glx/glxcmds.c b/src/glx/glxcmds.c
index 43c473b..837d8a2 100644
--- a/src/glx/glxcmds.c
+++ b/src/glx/glxcmds.c
@@ -1105,7 +1105,7 @@ static int
fbconfig_compare(struct glx_config **a, struct glx_config **b)
{
/* The order of these comparisons must NOT change. It is defined by
- * the GLX 1.3 spec and ARB_multisample.
+ * the GLX 1.4 specification.
*/
PREFER_SMALLER(visualSelectGroup);
@@ -1134,6 +1134,9 @@ fbconfig_compare(struct glx_config **a, struct glx_config **b)
PREFER_SMALLER(numAuxBuffers);
+ PREFER_SMALLER(sampleBuffers);
+ PREFER_SMALLER(samples);
+
PREFER_LARGER_OR_ZERO(depthBits);
PREFER_SMALLER(stencilBits);
@@ -1147,12 +1150,6 @@ fbconfig_compare(struct glx_config **a, struct glx_config **b)
PREFER_SMALLER(visualType);
- /* None of the multisample specs say where this comparison should happen,
- * so I put it near the end.
- */
- PREFER_SMALLER(sampleBuffers);
- PREFER_SMALLER(samples);
-
/* None of the pbuffer or fbconfig specs say that this comparison needs
* to happen at all, but it seems like it should.
*/
More information about the mesa-commit
mailing list