Mesa (master): glsl: Allow non-constant UBO array indexing with GLSL4/ ARB_gpu_shader5.

Chris Forbes chrisf at kemper.freedesktop.org
Sat Jul 26 04:43:01 UTC 2014


Module: Mesa
Branch: master
Commit: 8eae5ceb99b71854db566e18222f400641c23f39
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=8eae5ceb99b71854db566e18222f400641c23f39

Author: Chris Forbes <chrisf at ijw.co.nz>
Date:   Fri May 16 21:10:18 2014 +1200

glsl: Allow non-constant UBO array indexing with GLSL4/ARB_gpu_shader5.

Signed-off-by: Chris Forbes <chrisf at ijw.co.nz>
Reviewed-by: Ilia Mirkin <imirkin at alum.mit.edu>
Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>

---

 src/glsl/ast_array_index.cpp |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/glsl/ast_array_index.cpp b/src/glsl/ast_array_index.cpp
index f3b060e..50f9987 100644
--- a/src/glsl/ast_array_index.cpp
+++ b/src/glsl/ast_array_index.cpp
@@ -181,7 +181,8 @@ _mesa_ast_array_index_to_hir(void *mem_ctx,
       if (array->type->is_unsized_array()) {
 	 _mesa_glsl_error(&loc, state, "unsized array index must be constant");
       } else if (array->type->fields.array->is_interface()
-                 && array->variable_referenced()->data.mode == ir_var_uniform) {
+                 && array->variable_referenced()->data.mode == ir_var_uniform
+                 && !state->is_version(400, 0) && !state->ARB_gpu_shader5_enable) {
 	 /* Page 46 in section 4.3.7 of the OpenGL ES 3.00 spec says:
 	  *
 	  *     "All indexes used to index a uniform block array must be




More information about the mesa-commit mailing list