Mesa (master): i965: Drop unnecessary brw_set_conditionalmod() before brw_CMP().

Kenneth Graunke kwg at kemper.freedesktop.org
Mon Jun 2 22:09:30 UTC 2014


Module: Mesa
Branch: master
Commit: 0985da542366cb6be8dc287db4a74c828a7e8fa4
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=0985da542366cb6be8dc287db4a74c828a7e8fa4

Author: Kenneth Graunke <kenneth at whitecape.org>
Date:   Wed May 28 00:02:18 2014 -0700

i965: Drop unnecessary brw_set_conditionalmod() before brw_CMP().

brw_CMP already takes a conditional modifier as a parameter, and sets it
accordingly.  brw_set_conditionalmod() also makes everything after the
next instruction predicated, but we don't need that: we always emit an
IF instruction after load_clip_distance(), and that's already
predicated.

Signed-off-by: Kenneth Graunke <kenneth at whitecape.org>
Reviewed-by: Matt Turner <mattst88 at gmail.com>

---

 src/mesa/drivers/dri/i965/brw_clip_tri.c |    1 -
 1 file changed, 1 deletion(-)

diff --git a/src/mesa/drivers/dri/i965/brw_clip_tri.c b/src/mesa/drivers/dri/i965/brw_clip_tri.c
index 9edfa2e..289f4cc 100644
--- a/src/mesa/drivers/dri/i965/brw_clip_tri.c
+++ b/src/mesa/drivers/dri/i965/brw_clip_tri.c
@@ -252,7 +252,6 @@ load_clip_distance(struct brw_clip_compile *c, struct brw_indirect vtx,
    }
    brw_ENDIF(p);
 
-   brw_set_conditionalmod(p, cond);
    brw_CMP(p, brw_null_reg(), cond, vec1(dst), brw_imm_f(0.0f));
 }
 




More information about the mesa-commit mailing list