Mesa (master): target-helpers: add a note about debug wrappers
Emil Velikov
evelikov at kemper.freedesktop.org
Thu Jun 19 11:47:18 UTC 2014
Module: Mesa
Branch: master
Commit: 1e414faa5edaafcdb1b90f8ddefa6aad77386d4d
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=1e414faa5edaafcdb1b90f8ddefa6aad77386d4d
Author: Emil Velikov <emil.l.velikov at gmail.com>
Date: Wed May 14 18:48:49 2014 +0100
target-helpers: add a note about debug wrappers
If memory serves me right, at least one debug wrapper does
not return the base screen on failure.
Signed-off-by: Emil Velikov <emil.l.velikov at gmail.com>
---
src/gallium/auxiliary/target-helpers/inline_debug_helper.h | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/src/gallium/auxiliary/target-helpers/inline_debug_helper.h b/src/gallium/auxiliary/target-helpers/inline_debug_helper.h
index 77c7cfd..6fe667d 100644
--- a/src/gallium/auxiliary/target-helpers/inline_debug_helper.h
+++ b/src/gallium/auxiliary/target-helpers/inline_debug_helper.h
@@ -26,6 +26,10 @@
#include "noop/noop_public.h"
#endif
+/*
+ * TODO: Audit the following *screen_create() - all of
+ * them should return the original screen on failuire.
+ */
static INLINE struct pipe_screen *
debug_screen_wrap(struct pipe_screen *screen)
{
More information about the mesa-commit
mailing list