Mesa (10.1): mesa: Remove glClear optimization based on drawable size

Carl Worth cworth at kemper.freedesktop.org
Mon Jun 23 23:30:00 UTC 2014


Module: Mesa
Branch: 10.1
Commit: 68af044a0c6a4180c2edc3c60c464cb6be9a2bde
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=68af044a0c6a4180c2edc3c60c464cb6be9a2bde

Author: Kristian Høgsberg <krh at bitplanet.net>
Date:   Mon May 12 15:46:11 2014 -0700

mesa: Remove glClear optimization based on drawable size

A drawable size of 0x0 means that we don't have buffers for a drawable yet,
not that we have a zero-sized buffer.  Core mesa shouldn't be optimizing out
drawing based on buffer size, since the draw call could be what triggers
the driver to go and get buffers.  As discussed in the referenced bug report,
the optimization was added as part of a scatter-shot attempt to fix a
different problem.  There's no other example in mesa core of using the
buffer size in this way.

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=74005
Cc: "10.1 10.2" <mesa-stable at lists.freedesktop.org>
Signed-off-by: Kristian Høgsberg <krh at bitplanet.net>
Reviewed-by: Ian Romanick <ian.d.romanick at intel.com>
(cherry picked from commit 7928b946adbcbbb835c0080967bbb538f6bd35dc)

---

 src/mesa/main/clear.c |    5 -----
 1 file changed, 5 deletions(-)

diff --git a/src/mesa/main/clear.c b/src/mesa/main/clear.c
index 077c5fc..c3f7474 100644
--- a/src/mesa/main/clear.c
+++ b/src/mesa/main/clear.c
@@ -155,11 +155,6 @@ _mesa_Clear( GLbitfield mask )
       return;
    }
 
-   if (ctx->DrawBuffer->Width == 0 || ctx->DrawBuffer->Height == 0 ||
-       ctx->DrawBuffer->_Xmin >= ctx->DrawBuffer->_Xmax ||
-       ctx->DrawBuffer->_Ymin >= ctx->DrawBuffer->_Ymax)
-      return;
-
    if (ctx->RasterDiscard)
       return;
 




More information about the mesa-commit mailing list