Mesa (master): i965/fs: Set fs_inst::header_present for untyped atomics/ surface reads.

Kenneth Graunke kwg at kemper.freedesktop.org
Thu May 1 07:24:58 UTC 2014


Module: Mesa
Branch: master
Commit: f1cd9fee53f743ed4621c2541f0058a874b4bea1
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=f1cd9fee53f743ed4621c2541f0058a874b4bea1

Author: Kenneth Graunke <kenneth at whitecape.org>
Date:   Fri Apr 18 10:22:13 2014 -0700

i965/fs: Set fs_inst::header_present for untyped atomics/surface reads.

The brw_eu_emit.c code manually forces the header present bit when
used in align1 (scalar) mode.  So, this has no effect currently.

However, it is nice to have fs_inst::header_present reflect reality.

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=77221
Signed-off-by: Kenneth Graunke <kenneth at whitecape.org>
Reviewed-by: Eric Anholt <eric at anholt.net>

---

 src/mesa/drivers/dri/i965/brw_fs_visitor.cpp |    2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/mesa/drivers/dri/i965/brw_fs_visitor.cpp b/src/mesa/drivers/dri/i965/brw_fs_visitor.cpp
index aa177cb..d2dc5fa 100644
--- a/src/mesa/drivers/dri/i965/brw_fs_visitor.cpp
+++ b/src/mesa/drivers/dri/i965/brw_fs_visitor.cpp
@@ -2414,6 +2414,7 @@ fs_visitor::emit_untyped_atomic(unsigned atomic_op, unsigned surf_index,
                                         atomic_op, surf_index);
    inst->base_mrf = 0;
    inst->mlen = mlen;
+   inst->header_present = true;
    emit(inst);
 }
 
@@ -2448,6 +2449,7 @@ fs_visitor::emit_untyped_surface_read(unsigned surf_index, fs_reg dst,
       fs_inst(SHADER_OPCODE_UNTYPED_SURFACE_READ, dst, surf_index);
    inst->base_mrf = 0;
    inst->mlen = mlen;
+   inst->header_present = true;
    emit(inst);
 }
 




More information about the mesa-commit mailing list