Mesa (master): scons: Adjust the warnings for VS.

Jose Fonseca jrfonseca at kemper.freedesktop.org
Fri May 2 21:06:31 UTC 2014


Module: Mesa
Branch: master
Commit: 42b9f8590d3002bc04b08397031b80e4a4d6e921
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=42b9f8590d3002bc04b08397031b80e4a4d6e921

Author: José Fonseca <jfonseca at vmware.com>
Date:   Thu May  1 15:40:43 2014 +0100

scons: Adjust the warnings for VS.

Silence insignificant warnings so significant warnings have a chance to
stand out.

The only abundant warning that's not silenced here is "C4018:
signed/unsigned mismatch", as it could hide security issues, so it's better
to actually fix the code.

Reviewed-by: Brian Paul <brianp at vmware.com>
Reviewed-by: Roland Scheidegger <sroland at vmware.com>

---

 scons/gallium.py |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/scons/gallium.py b/scons/gallium.py
index d13d0e6..ca317b0 100755
--- a/scons/gallium.py
+++ b/scons/gallium.py
@@ -455,7 +455,9 @@ def generate(env):
             ]
         ccflags += [
             '/W3', # warning level
-            #'/Wp64', # enable 64 bit porting warnings
+            '/wd4244', # conversion from 'type1' to 'type2', possible loss of data
+            '/wd4305', # truncation from 'type1' to 'type2'
+            '/wd4800', # forcing value to bool 'true' or 'false' (performance warning)
             '/wd4996', # disable deprecated POSIX name warnings
         ]
         if env['machine'] == 'x86':




More information about the mesa-commit mailing list