Mesa (master): darwin: Fix test for kCGLPFAOpenGLProfile support at runtime

Jeremy Huddleston jeremyhu at kemper.freedesktop.org
Tue May 20 17:53:58 UTC 2014


Module: Mesa
Branch: master
Commit: 7a109268ab5b3544e7f7b99e84ef1fdf54023fb4
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=7a109268ab5b3544e7f7b99e84ef1fdf54023fb4

Author: Jeremy Huddleston Sequoia <jeremyhu at apple.com>
Date:   Tue May 20 10:53:00 2014 -0700

darwin: Fix test for kCGLPFAOpenGLProfile support at runtime

Signed-off-by: Jeremy Huddleston Sequoia <jeremyhu at apple.com>

---

 src/glx/apple/apple_visual.c |   14 +++++++++-----
 1 file changed, 9 insertions(+), 5 deletions(-)

diff --git a/src/glx/apple/apple_visual.c b/src/glx/apple/apple_visual.c
index 282934f..238c248 100644
--- a/src/glx/apple/apple_visual.c
+++ b/src/glx/apple/apple_visual.c
@@ -73,11 +73,15 @@ apple_visual_create_pfobj(CGLPixelFormatObj * pfobj, const struct glx_config * m
    GLint vsref = 0;
    CGLError error = 0;
 
-   /* Request an OpenGL 3.2 profile if one is available */
-   if(apple_cgl.version_major > 1 || (apple_cgl.version_major == 1 && apple_cgl.version_minor >= 3)) {
-      attr[numattr++] = kCGLPFAOpenGLProfile;
-      attr[numattr++] = kCGLOGLPVersion_3_2_Core;
-   }
+   /* Request an OpenGL 3.2 profile if one is available and supported */
+   attr[numattr++] = kCGLPFAOpenGLProfile;
+   attr[numattr++] = kCGLOGLPVersion_3_2_Core;
+
+   /* Test for kCGLPFAOpenGLProfile support at runtime and roll it out if not supported */
+   attr[numattr] = 0;
+   error = apple_cgl.choose_pixel_format(attr, pfobj, &vsref);
+   if (error == kCGLBadAttribute)
+      numattr -= 2;
 
    if (offscreen) {
       apple_glx_diagnostic




More information about the mesa-commit mailing list