Mesa (master): i965/sf: Drop useless push/ pop state from flag register mashing code.

Kenneth Graunke kwg at kemper.freedesktop.org
Tue May 27 21:22:17 UTC 2014


Module: Mesa
Branch: master
Commit: 41afb3ade46c9a10c7a1e61df55c7b51281b0247
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=41afb3ade46c9a10c7a1e61df55c7b51281b0247

Author: Kenneth Graunke <kenneth at whitecape.org>
Date:   Sun May 25 01:08:51 2014 -0700

i965/sf: Drop useless push/pop state from flag register mashing code.

There's no point in pushing and popping the default state; the code
between the two stack operations doesn't alter anything.

Signed-off-by: Kenneth Graunke <kenneth at whitecape.org>
Reviewed-by: Matt Turner <mattst88 at gmail.com>

---

 src/mesa/drivers/dri/i965/brw_eu.c |    2 --
 1 file changed, 2 deletions(-)

diff --git a/src/mesa/drivers/dri/i965/brw_eu.c b/src/mesa/drivers/dri/i965/brw_eu.c
index 95bffc4..e854a79 100644
--- a/src/mesa/drivers/dri/i965/brw_eu.c
+++ b/src/mesa/drivers/dri/i965/brw_eu.c
@@ -98,10 +98,8 @@ void brw_set_predicate_control_flag_value( struct brw_compile *p, unsigned value
 
    if (value != 0xff) {
       if (value != p->flag_value) {
-	 brw_push_insn_state(p);
 	 brw_MOV(p, brw_flag_reg(0, 0), brw_imm_uw(value));
 	 p->flag_value = value;
-	 brw_pop_insn_state(p);
       }
 
       p->current->header.predicate_control = BRW_PREDICATE_NORMAL;




More information about the mesa-commit mailing list