Mesa (master): i965/sf: Drop unnecessary push/pop in do_twoside_color.

Kenneth Graunke kwg at kemper.freedesktop.org
Tue May 27 21:22:17 UTC 2014


Module: Mesa
Branch: master
Commit: 2747f6a1f9d27826346d330cceef44b800267bcb
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=2747f6a1f9d27826346d330cceef44b800267bcb

Author: Kenneth Graunke <kenneth at whitecape.org>
Date:   Sun May 25 01:08:50 2014 -0700

i965/sf: Drop unnecessary push/pop in do_twoside_color.

None of the assembly emitters called between push and pop actually
change the state.  So, we can drop these.

Signed-off-by: Kenneth Graunke <kenneth at whitecape.org>
Reviewed-by: Matt Turner <mattst88 at gmail.com>

---

 src/mesa/drivers/dri/i965/brw_sf_emit.c |    2 --
 1 file changed, 2 deletions(-)

diff --git a/src/mesa/drivers/dri/i965/brw_sf_emit.c b/src/mesa/drivers/dri/i965/brw_sf_emit.c
index 96be91a..475d489 100644
--- a/src/mesa/drivers/dri/i965/brw_sf_emit.c
+++ b/src/mesa/drivers/dri/i965/brw_sf_emit.c
@@ -137,7 +137,6 @@ static void do_twoside_color( struct brw_sf_compile *c )
     * we run with NoMask, so it's not an option and we can use
     * BRW_EXECUTE_1 for all comparisions.
     */
-   brw_push_insn_state(p);
    brw_CMP(p, vec4(brw_null_reg()), backface_conditional, c->det, brw_imm_f(0));
    brw_IF(p, BRW_EXECUTE_4);
    {
@@ -148,7 +147,6 @@ static void do_twoside_color( struct brw_sf_compile *c )
       }
    }
    brw_ENDIF(p);
-   brw_pop_insn_state(p);
 }
 
 




More information about the mesa-commit mailing list